git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[GSoC] [RFC] Unify ref-filter formats with other --pretty formats

From
KJKapil Jain <jkapil.cs@gmail.com>
Date
Apr 3, 2019, 19:54 UTC
Message-ID
<CAMknYEPzUpa3c9PSfJNo6rzUOt-bDUDYrcn9JcHgSGW43KuRYg@mail.gmail.com>
Reference: https://git.github.io/SoC-2019-Ideas/#unify-ref-filter-formats-with-other---pretty-formats
I have spent some time with both pretty.* and ref-filter.*

First off, we are aiming to reuse ref-filter, so avoiding any sort of re-implementation is recommended.

Now, coming to pretty.* and ref-filter.*

suppose, a function named xyz() in ref-filter.c seems like it could be reused in pretty.c. since ref-filter doesn't use any struct of pretty.c. The xyz() function in its original form is not useful for pretty.c. So now, in order for the xyz() function to be useful in pretty.c. Function xyz() should be using structs of pretty.*

now, if we make xyz() use the pretty.* structs, then its re-implementation and not reusing. its like keeping two different functions one for ref-filter and another for pretty.*. which is what is already happening.

please provide any starting point for reusing ref-filter. i don't see any in pretty.*. reusing ref-filter specifically in pretty.* is not the motive. please point out any file in entire code base, that you may feel can reuse some ref-filter logic.

Next: Olga Telezhnaya
Message 1 of 2 in “[GSoC] [RFC] Unify ref-filter formats with other --pretty formats”
  1. Kapil JainApr 3, 2019
  2. Olga TelezhnayaApr 4, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.