git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC] TODO in read-cache.c

From
KJKapil Jain <jkapil.cs@gmail.com>
Date
Apr 6, 2019, 11:40 UTC
Message-ID
<CAMknYEPS68VEkUbNxeKQvVDGjzVpBXKNAi3uA04pLwN9k4ZTfA@mail.gmail.com>

i found some TODO tasks inside `read-cache.c` in `read_index_from()` function. which says:

/*
* TODO trace2: replace "the_repository" with the actual repo instance
that is associated with the given "istate".
*/
this same TODO occurs at 4 other places in the same file.

Will it be ok, if i complete this TODO by modifying the trace2's function signatures to accept `struct repository` and change the calls to those functions accordingly ?

Next: Duy Nguyen
Message 1 of 7 in “[RFC] TODO in read-cache.c”
  1. Kapil JainApr 6, 2019
  2. Duy NguyenApr 6, 2019
  3. Kapil JainApr 6, 2019
  4. Duy NguyenApr 6, 2019
  5. Kapil JainApr 6, 2019
  6. Duy NguyenApr 7, 2019
  7. Taylor BlauApr 9, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.