[RFC] TODO in read-cache.c
- From
- Kapil Jain <jkapil.cs@gmail.com>
- Date
- Apr 6, 2019, 11:40 UTC
- Message-ID
- <CAMknYEPS68VEkUbNxeKQvVDGjzVpBXKNAi3uA04pLwN9k4ZTfA@mail.gmail.com>
i found some TODO tasks inside `read-cache.c` in `read_index_from()` function. which says:
/* * TODO trace2: replace "the_repository" with the actual repo instance that is associated with the given "istate". */
this same TODO occurs at 4 other places in the same file.
Will it be ok, if i complete this TODO by modifying the trace2's function signatures to accept `struct repository` and change the calls to those functions accordingly ?