Re: What's cooking in git.git (Apr 2012, #08; Fri, 20)

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 22, 2012, 15:05 UTC
Message-ID: <CAMP44s3yy9yQ+KDtcit2RQeCs1GXx3G4F=FZJ36Jt5jgO8ZsgQ@mail.gmail.com>
In-Reply-To: <xmqq8vhomj7w.fsf@junio.mtv.corp.google.com>

On Sun, Apr 22, 2012 at 8:25 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 18 quoted lines

> SZEDER Gábor <szeder@ira.uka.de> writes:
>
>> On Fri, Apr 20, 2012 at 05:06:20PM -0700, Junio C Hamano wrote:
>>> * fc/completion-tests (2012-04-18) 7 commits
>>>  - tests: add tests for the __gitcomp() completion helper function
>>>  - completion: fix completion after 'git --option <TAB>'
>>>  - completion: avoid trailing space for --exec-path
>>>  - completion: add missing general options
>>>  - completion: simplify by using $prev
>>>  - completion: simplify __gitcomp_1
>>>  - tests: add initial bash completion tests
>>
>> Perhaps you could move 'tests: add tests for the __gitcomp()
>> completion helper function' from the top after 'tests: add initial
>> bash completion tests', to show that Felipe's 'completion: simplify
>> __gitcomp_1' doesn't break any of the tests.
>
> I don't mind.  Felipe, what do you think?

Fine by me.

-- 
Felipe Contreras