Re: [PATCH 1/8] rebase: simplify code related to imply_merge()
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- Mar 23, 2023, 21:08 UTC
- Message-ID
- <CAMP44s3g5FZ5VgvF27h4AzqHrxpOvYtG9RRVr=TJTkTAGxBKqg@mail.gmail.com>
- In-Reply-To
- <xmqqiler8cga.fsf@gitster.g>
On Thu, Mar 23, 2023 at 2:07 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 14 quoted lines
> > Phillip Wood <phillip.wood123@gmail.com> writes: > > > On 23/03/2023 16:22, Oswald Buddenhagen wrote: > >> The code's evolution left in some bits surrounding enum rebase_type that > >> don't really make sense any more. In particular, it makes no sense to > >> invoke imply_merge() if the type is already known not to be > >> REBASE_APPLY, and it makes no sense to assign the type after calling > >> imply_merge(). > > > > These look sensible, did imply_merges() use to do something more which > > made these calls useful? > > Good question.
It used to be called imply_interactive(), so --merge did require an interactive rebase.
-- Felipe Contreras