Re: [PATCH] completion: fix issues with COMP_WORDBREAKS

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 16, 2012, 10:44 UTC
Message-ID: <CAMP44s3cM5nZnN6W6KCw-aVdT_-Ax1YTopHkR6b0msSsHhQDmA@mail.gmail.com>
In-Reply-To: <20120416003850.GH5813@burratino>

On Mon, Apr 16, 2012 at 3:38 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 20 quoted lines

> Felipe Contreras wrote:
>
>> In fact if COMP_WORDBREAKS doesn't contain a colon the completion gets
>> all messed up. For example:
>>
>>  git push origin master:<TAB>
>>  git diff master:<TAB>
>>
>> The "master:" prefix would be added again, unnecessarily.
>
> Thanks.  Yeah, that sounds broken.
>
> Unfortunately the patch introduces a regression: if after loading the
> completion script I set COMP_WORDBREAKS not to contain a colon, then
> with the current completion script
>
>        git show HEAD:Docu<TAB>
>
> completes fine, but with the patched completion script it seems to
> get confused and strips off the HEAD.

I don't understand, I tested this and it was working fine, but not any more =/

Maybe I was testing on zsh.

I guess this should be dropped then.

Cheers.

-- 
Felipe Contreras