Re: [PATCH v2] Fix git-completion.bash for use in zsh

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Mar 25, 2012, 17:47 UTC
Message-ID: <CAMP44s3_aZ39n6L15ZUNyw8B_6ab+=_Hm8-KPz6WM26GweJCmg@mail.gmail.com>
In-Reply-To: <7vaa393mvc.fsf@alter.siamese.dyndns.org>

On Wed, Mar 21, 2012 at 7:05 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 15 quoted lines

> Alex Merry <dev@randomguy3.me.uk> writes:
>
>> zsh treats
>>   local some_var=()
>> as a function declaration, rather than an array declaration (although
>> its documentation does not suggest that this should be the case).
>>
>> With zsh 4.3.15 on Fedora Core 15, this causes
>>   __git_ps1 " (%s)"
>> to produce the message
>>   local:2: command not found: svn_url_pattern
>> when GIT_PS1_SHOWUPSTREAM="auto", due to the line
>>   local svn_remote=() svn_url_pattern count n
>
> Thanks, will queue.  Felipe, comments?

Looks good to me. Also, I tested this, and it worked.

-- 
Felipe Contreras