git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] remote-bzr: reuse bzrlib transports when possible

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Sep 8, 2013, 00:27 UTC
Message-ID
<CAMP44s3Vw4GX+yL22F49uKFZcEvYmXC7nT9TCGW_jybhFHo1Og@mail.gmail.com>
In-Reply-To
<1378598300-22737-1-git-send-email-rhansen@bbn.com>
On Sat, Sep 7, 2013 at 6:58 PM, Richard Hansen <rhansen@bbn.com> wrote:
Show 17 quoted lines
> Pass a list of open bzrlib.transport.Transport objects to each bzrlib
> function that might create a transport.  This enables bzrlib to reuse
> existing transports when possible, avoiding multiple concurrent
> connections to the same remote server.
>
> If the remote server is accessed via ssh, this fixes a couple of
> problems:
>   * If the user does not have keys loaded into an ssh agent, the user
>     may be prompted for a password multiple times.
>   * If the user is using OpenSSH and the ControlMaster setting is set
>     to auto, git-remote-bzr might hang.  This is because bzrlib closes
>     the multiple ssh sessions in an undefined order and might try to
>     close the master ssh session before the other sessions.  The
>     master ssh process will not exit until the other sessions have
>     exited, causing a deadlock.  (The ssh sessions are closed in an
>     undefined order because bzrlib relies on the Python garbage
>     collector to trigger ssh session termination.)
Looks good to me. I'll apply in my personal repository.
-- 
Felipe Contreras
Previous: Junio C Hamano
Message 10 of 10 in “remote-bzr: reuse bzrlib transports when possible”
  1. remote-bzr: reuse bzrlib transports when possibleRichard Hansen, Sep 7, 2013
  2. Richard HansenSep 8, 2013
  3. Felipe ContrerasSep 8, 2013
  4. Richard HansenSep 8, 2013
  5. remote-bzr: reuse bzrlib transports when possibleRichard Hansen, Sep 8, 2013
  6. Junio C HamanoSep 9, 2013
  7. Junio C HamanoSep 10, 2013
  8. Richard HansenSep 12, 2013
  9. Junio C HamanoSep 12, 2013
  10. Felipe ContrerasSep 8, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.