Re: [PATCH] Add new @ shortcut for HEAD

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 30, 2013, 23:19 UTC
Message-ID: <CAMP44s3QT5z1iWsm0cvQDfmZBp_kWbXatQKGaj8H3kzgdK=QFw@mail.gmail.com>
In-Reply-To: <CAMP44s3L6X=iWK7S-JFqp42PmNx4xbh-GnPJpAgur4FGoZYNbg@mail.gmail.com>

On Tue, Apr 30, 2013 at 6:00 PM, Felipe Contreras <felipe.contreras@gmail.com> wrote:

Show 15 quoted lines

> +static int interpret_empty_at(const char *name, int namelen, int len,
> struct strbuf *buf)
> +{
> +       if (namelen - len < 1 || name[len + 1] == '{')
> +               return -1;
> +
> +       strbuf_reset(buf);
> +       if (len == 0) {
> +               strbuf_add(buf, "HEAD", 4);
> +               return 1;
> +       } else {
> +               strbuf_add(buf, name, len);
> +               return len + 1;
> +       }
> +}

Hmm, it's not correct, and besides, if we don't parse 'master@', it's much simpler:

/* parse @something syntax, when 'something' is not {.*} */
static int interpret_empty_at(const char *name, int namelen, int len,
struct strbuf *buf)
{
	if (len || (namelen > 1 && name[1] == '{'))
		return -1;

	strbuf_reset(buf);
	strbuf_add(buf, "HEAD", 4);
	return 1;
}

-- 
Felipe Contreras