Re: [PATCH v4 4/4] completion: simplify __gitcomp*

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Feb 5, 2012, 21:14 UTC
Message-ID: <CAMP44s3ECM2e08wsjMzu9Y4xDRw+KVNbMdCeAmxiPn3jNtC59Q@mail.gmail.com>
In-Reply-To: <7vmx8xggan.fsf@alter.siamese.dyndns.org>

2012/2/5 Junio C Hamano <gitster@pobox.com>:

Show 12 quoted lines

> SZEDER Gábor <szeder@ira.uka.de> writes:
>
>> And it does make a difference, it breaks the completion of a single
>> word in multiple steps, e.g. git log --pretty=<TAB> master..<TAB>.  In
>> such cases we pass "${cur##--pretty=}" and "${cur_#*..}" as third
>> argument to __gitcomp() and __gitcomp_nl(), which can be empty strings
>> when the user hits TAB right after the '=' and '..'.
>
> After saying "this rewrite is wrong", I was actually wondering if I should
> have said "this rewrite is not faithful to the original".  Based on your
> analysis, the difference does break the callers, so the rewrite is indeed
> wrong.

That's why we need tests for the completion stuff as well. I was thinking on doing that, but if I have to write a peer-reviewed essay with an introduction for the people that are not familiar with the code in each of the patches, I'd rather not.

-- 
Felipe Contreras