Re: [PATCH] branch: colour upstream branches

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 14, 2013, 23:22 UTC
Message-ID: <CAMP44s2j-Cqksu29fJRTqDNGBNi1tZkE0gfgj69K-ckFwVgnRg@mail.gmail.com>
In-Reply-To: <CACsJy8DdBkPDXORxv08cFi+i5Q4WiBjjbNf9GyB4hv+t-K=wRQ@mail.gmail.com>

On Sun, Apr 14, 2013 at 5:31 PM, Duy Nguyen <pclouds@gmail.com> wrote:

Show 16 quoted lines

> On Sun, Apr 14, 2013 at 11:46 AM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>> +       char fancy[80];
>>
>> -       if (show_upstream_ref)
>> +       if (show_upstream_ref) {
>>                 ref = shorten_unambiguous_ref(branch->merge[0]->dst, 0);
>> +               if (want_color(branch_use_color))
>> +                       snprintf(fancy, sizeof(fancy), "%s%s%s",
>> +                                       GIT_COLOR_BLUE, ref, GIT_COLOR_RESET);
>> +               else
>> +                       strncpy(fancy, ref, sizeof(fancy));
>> +       }
>> +
>
> Please use strbuf for "fancy".

Why? We would need to initialize and free it. What's the advantage?

-- 
Felipe Contreras