Re: [PATCH] remote-hg: skip ill-formed references

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Aug 31, 2013, 01:39 UTC
Message-ID: <CAMP44s2f7S4STbCOuh35sgdrgAdw-2Tw1LDkjhO37hXLxX3mRQ@mail.gmail.com>
In-Reply-To: <20130831011542.GA10486@wheezy.local>

On Fri, Aug 30, 2013 at 8:15 PM, Max Kirillov <max@max630.net> wrote:

Show 10 quoted lines

> References which fail check_refname_format() cause the whole
> import to fail. This might be undesirable if the references
> are not important.
>
> A better solution would be to provide some mapping, either
> by some reversible encoding, or by generating and storing
> the associations locally.
>
> But this is already going to allow working with many
> existing repositories.

Which repository triggered this?

Maybe we should do something similar as in git-remote-bzr:

def ref_is_valid(name):
    return not True in [c in name for c in '~^: \\']

        if not ref_is_valid(tag):
            continue
        print "? refs/tags/%s" % tag

-- 
Felipe Contreras