Re: [PATCH 2/2] transport-helper: fix remote helper namespace regression

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 10, 2013, 20:36 UTC
Message-ID: <CAMP44s2QHd7b2t654hnMw_xca0OJKjUjEgP2yU4PUe-w4z-zBg@mail.gmail.com>
In-Reply-To: <7vsj1uzijo.fsf@alter.siamese.dyndns.org>

On Fri, May 10, 2013 at 3:28 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> +test_expect_success 'push update refs failure' '
>> +     (cd local &&
>> +     git checkout update &&
>> +     echo "update fail" >>file &&
>> +     git commit -a -m "update fail" &&
>> +     git rev-parse --verify testgit/origin/heads/update >expect &&
>> +     GIT_REMOTE_TESTGIT_PUSH_ERROR="non-fast forward" \
>> +     test_expect_code 1 git push origin update &&
>
> This is not portable

Why not? Other parts of this script run commands with environment variables like this.

-- 
Felipe Contreras