git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5] completion: add new __git_complete helper

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 14, 2012, 19:53 UTC
Message-ID
<CAMP44s2L=s4bd-sDcY3RWLWe9=YzLgC7UavgnE6K0akMCJSK4w@mail.gmail.com>
In-Reply-To
<7vaa1ah95p.fsf@alter.siamese.dyndns.org>
On Mon, May 14, 2012 at 9:09 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>>> Here is my attempt to explain why none of them needs to be quoted:
>>> ...
>> I don't understand that.
>
> That was my attempt to give the readers some context to understand what
> comes after that.  If the original patch author does not understand it,
> perhaps it is an indication that the function is somewhat underdocumented.

I mean I don't understand this "Note that none of the variable reference in the implementation of this function needs dq around it." I suppose you meant 'references' (as that would make it grammatically correct AFAICS), but I still don't understand what you are trying so say. That the way the arguments are used in the __git_complete function makes it so double quotes are irrelevant?

If so, then yeah, I agree.
Is there something actionable?
-- 
Felipe Contreras
Previous: Junio C HamanoNext: Junio C Hamano
Message 8 of 11 in “completion: add new __git_complete helper”
  1. completion: add new __git_complete helperFelipe Contreras, May 14, 2012
  2. Felipe ContrerasMay 14, 2012
  3. Junio C HamanoMay 14, 2012
  4. Felipe ContrerasMay 14, 2012
  5. Junio C HamanoMay 14, 2012
  6. Felipe ContrerasMay 14, 2012
  7. Junio C HamanoMay 14, 2012
  8. Felipe ContrerasMay 14, 2012
  9. Junio C HamanoMay 15, 2012
  10. Junio C HamanoMay 15, 2012
  11. Felipe ContrerasMay 16, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.