Re: [PATCH 1/4] remote-hg: add missing config for basic tests

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Nov 13, 2012, 03:46 UTC
Message-ID: <CAMP44s2GzX_+6+eNU5n6kGue_-MWvU9qNXAr3Caw3A7nWhkawA@mail.gmail.com>
In-Reply-To: <20121112203207.GF4623@sigill.intra.peff.net>

On Mon, Nov 12, 2012 at 9:32 PM, Jeff King <peff@peff.net> wrote:

Show 18 quoted lines

> On Mon, Nov 12, 2012 at 06:41:05PM +0100, Felipe Contreras wrote:
>
>> From: Ramkumar Ramachandra <artagnon@gmail.com>
>>
>> 'hg commit' fails otherwise in some versiosn of mercurial because of
>
> s/versiosn/versions/
>
>> +setup () {
>> +     (
>> +     echo "[ui]"
>> +     echo "username = A U Thor <author@example.com>"
>> +     ) >> "$HOME"/.hgrc
>> +}
>
> This makes sense, but I wonder if we should use something different from
> the git author ident set up by the test scripts, just to double check
> that we do not have any bugs in confusing the two during the import.

I don't know, but these tests would not check for any of those issues. When such tests are added I would prefer the author to use to be explicitly defined, but lets see.

-- 
Felipe Contreras