Re: [PATCH v2 00/16] Make Gnome Credential helper more Gnome-y and support ancient distros

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Sep 23, 2013, 20:15 UTC
Message-ID: <CAMP44s2G9=eheeyhXB06cH6mDL_nx3OkZics0bTLzRpxYiXt9Q@mail.gmail.com>
In-Reply-To: <1379962157-1338-1-git-send-email-bcasey@nvidia.com>

On Mon, Sep 23, 2013 at 1:49 PM, Brandon Casey <bcasey@nvidia.com> wrote:

Show 17 quoted lines

> From: Brandon Casey <drafnel@gmail.com>
>
> Mostly unchanged.
>
> Inserts a patch to fix the style issues for block statements.
> i.e. use "if ()" instead of "if()"
>
> A couple early patches were reordered to improve logical flow.
>
> Updated the comment in the last patch to hopefully improve clarity
> wrt RHEL 4.X
>
> The only functional change is in 14/16 "report failure to store".
> We should accept GNOME_KEYRING_RESULT_CANCELLED as a successful
> return and _not_ produce an error message.
>
> Interdiff follows...

I'm familiar with GLib and I looked at the patches, they look good to me.

-- 
Felipe Contreras