git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] completion: clean up __gitcomp() tests

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Oct 17, 2012, 18:21 UTC
Message-ID
<CAMP44s2Daj-yvTqKc-fMiqvA64z_odZy_dhGvtB7rM--LbuQRQ@mail.gmail.com>
In-Reply-To
<20121017175428.GF2156@goldbirke>
On Wed, Oct 17, 2012 at 7:54 PM, SZEDER Gábor <szeder@ira.uka.de> wrote:
Show 11 quoted lines
> Clean up two issues in the tests I added in 74a8c849 (tests: add tests
> for the __gitcomp() completion helper function, 2012-04-17):
>
>  - The COMPREPLY array is created using 'local -a' while in a
>    subshell.  However, the local keyword should only be used in a
>    shell function, and a variable created in a subshell is by
>    definition local to that subshell.  Use 'declare -a' instead.
>
>  - The contents of the COMPREPLY array is written through an IFS
>    fiddling + echo + redirection combo, although there is the
>    print_comp() helper function for exactly this purpose.
Makes sense. But this code seems awfully similar, a helper function might help.
-- 
Felipe Contreras
Previous: SZEDER GáborNext: Felipe Contreras
Message 10 of 14 in “completion: refactor and zsh wrapper”
  1. 0/3 completion: refactor and zsh wrapperFelipe Contreras, Oct 14, 2012
  2. 1/3 completion: add new __gitcompadd helperFelipe Contreras, Oct 14, 2012
  3. SZEDER GáborOct 17, 2012
  4. Felipe ContrerasOct 22, 2012
  5. SZEDER GáborOct 30, 2012
  6. 2/3 tests: use __gitcompadd to simplify completion testsFelipe Contreras, Oct 14, 2012
  7. Felipe ContrerasOct 16, 2012
  8. SZEDER GáborOct 17, 2012
  9. completion: clean up __gitcomp() testsSZEDER Gábor, Oct 17, 2012
  10. Felipe ContrerasOct 17, 2012
  11. Felipe ContrerasOct 17, 2012
  12. 3/3 completion: add new zsh completionFelipe Contreras, Oct 14, 2012
  13. Felipe ContrerasOct 15, 2012
  14. Matthieu MoyOct 15, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.