Re: [PATCH] remote-testgit: properly check for errors

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Oct 23, 2012, 00:57 UTC
Message-ID: <CAMP44s2=yxXGzUoxu=6baPv-6oq+UA9g1JdyqSSUYHS2800S2A@mail.gmail.com>
In-Reply-To: <CAGdFq_gOb3GX1iZshGZahZEbj3RqQSEk8AN_hHXKyD5aHwfxYA@mail.gmail.com>

On Mon, Oct 22, 2012 at 11:01 PM, Sverre Rabbelier <srabbelier@gmail.com> wrote:

Show 14 quoted lines

> On Mon, Oct 22, 2012 at 1:56 PM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>> diff --git a/git-remote-testgit.py b/git-remote-testgit.py
>> index 5f3ebd2..b8707e6 100644
>> --- a/git-remote-testgit.py
>> +++ b/git-remote-testgit.py
>> @@ -159,6 +159,11 @@ def do_import(repo, args):
>>          ref = line[7:].strip()
>>          refs.append(ref)
>>
>> +    print "feature done"
>
> There's not enough context for me to see in which part of the code
> this is, import or export?

Isn't this enough?

>> @@ -159,6 +159,11 @@ def do_import(repo, args):

It's import.

> If you advertise 'feature done', shouldn't
> you also print 'done' when you finish writing the fast-export stream?
> If that's already the case feel free to ignore me :)

It's already there: http://git.kernel.org/?p=git/git.git;a=blob;f=git-remote-testgit.py#l165

Cheers.

-- 
Felipe Contreras