Re: [PATCH 0/4] Re: [PATCH 3/4] t: rev-parse-parents: avoid yoda conditions

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Sep 3, 2013, 21:53 UTC
Message-ID: <CAMP44s1mnz2A20bNo2um9BhO=b3WOtOGWundXuH+5nYNNDcKxA@mail.gmail.com>
In-Reply-To: <20130903170419.GA29921@google.com>

On Tue, Sep 3, 2013 at 12:04 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 12 quoted lines

> SZEDER Gábor wrote:
>> On Tue, Sep 03, 2013 at 08:39:54AM -0500, Felipe Contreras wrote:
>
>>> There are two ways to fix an inconsistency, the other way is to fix
>>> test_cmp. But that would be a change, and change is not welcome in
>>> Git.
>>
>> It depends on the change, I suppose.  I agree, changing 3k+ lines just
>> to avoid yoda conditions...  I doubt the gain worth the code churn.
>
> Especially when the idiom being changed is not even being made better.
> ;-)

But it is better.

> test_cmp_rev follows the same order of arguments a "diff -u" and
> produces the same output as plain "git diff".  It's perfectly readable
> and normal.  I think Felipe is pushing buttons and testing boundaries.

Those are irrelevant implementation details.

-- 
Felipe Contreras