Re: [PATCH] send-email: add extra safetly in address sanitazion

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Feb 5, 2012, 21:20 UTC
Message-ID: <CAMP44s1NrGkz7sKz2CTF2XV9uGUfethg2+pcybPe2KBY02cnwA@mail.gmail.com>
In-Reply-To: <7v4nv5gf2n.fsf@alter.siamese.dyndns.org>

On Sun, Feb 5, 2012 at 11:12 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 17 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> On Sat, Feb 4, 2012 at 5:10 PM, Felipe Contreras
>> <felipe.contreras@gmail.com> wrote:
>>> Otherwise, 'git send-email' would be happy to do:
>>>
>>>  % git send-email --to '<foo@bar.com>>'
>>>
>>> And use '<foo@bar.com>>' in the headers.
>>
>> Er, actually that's not correct: '<foo@bar.com>>' will remain the
>> same, but 'Foo <foo@bar.com>>' will be sanitized.
>
> I suspect that this "Er" is merely a sympotom of a larger issue in the
> approach taken by this patch.  The code takes a potentially malformed
> input, and applies a rewrite logic without telling the user what it is
> doing.

That's what the function is doing already: sanitizing the address.

> Wouldn't a better approach to detect problem on the input side and reject
> a wrong one by erroring out, so that the user has a chance to fix?

Perhaps, but the code is not prepared for that. Anyway, feel free to drop it, I am not interested in pursing this.

Cheers.

-- 
Felipe Contreras