Re: [PATCH v2] transport-helper: check if the dry-run is supported
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- May 21, 2013, 21:14 UTC
- Message-ID
- <CAMP44s14ZBUYhxDkSwjoi+6JPx4whfQDhiq_4QfMteALsbuQ_Q@mail.gmail.com>
- In-Reply-To
- <7vli78p920.fsf@alter.siamese.dyndns.org>
On Tue, May 21, 2013 at 11:55 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 13 quoted lines
> Felipe Contreras <felipe.contreras@gmail.com> writes: > >> Certain remote-helpers (the ones with 'export') would try to push >> regardless. >> >> Obviously this is not what the user wants. >> >> Also, add a check for the 'dry-run' option, so remote-helpers can >> implement it. > > This sounds like a good thing to do. Perhaps the refspec mapping > can be handled the same way as a backend feature so that you do not > have to unconditionally disable it in the other patch.
With my patch the remote helper doesn't need to know about the refspec handling at all, it just works magically.
-- Felipe Contreras