Re: [PATCH v2] branch: colour upstream branches

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 15, 2013, 02:27 UTC
Message-ID: <CAMP44s0wLH0hyrj9xSn+LDS=nLbWuHavNeXv_U4NSYWyK5WncA@mail.gmail.com>
In-Reply-To: <7vd2tw4l2e.fsf@alter.siamese.dyndns.org>

On Sun, Apr 14, 2013 at 8:52 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 18 quoted lines

> Jeff King <peff@peff.net> writes:
>
>> On Sun, Apr 14, 2013 at 06:38:27PM -0500, Felipe Contreras wrote:
>>
>>> +            if (want_color(branch_use_color))
>>> +                    snprintf(fancy, sizeof(fancy), "%s%s%s",
>>> +                                    branch_get_color(BRANCH_COLOR_UPSTREAM),
>>> +                                    ref, branch_get_color(BRANCH_COLOR_RESET));
>>> +            else
>>> +                    strncpy(fancy, ref, sizeof(fancy));
>>
>>   $ man strncpy | grep -C1 Warning
>>   The strncpy() function is similar, except that at most n bytes of src are
>>   copied.  Warning: If there is no null byte among the first n bytes of src,
>>   the string placed in dest will not be null-terminated.
>
> Is there a reason to avoid strbuf_addf() here?  We are talking about
> output for human consumption and not performance critical code, no?

It's not about the performance, it's about the amount of code. But I already agreed to do this.

-- 
Felipe Contreras