Re: What's cooking in git.git (Dec 2013, #02; Fri, 6)

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Dec 7, 2013, 20:30 UTC
Message-ID: <CAMP44s0sankG67rknVo=g5aOJXS_GZBh+hkr9cyVSiYrEvt83Q@mail.gmail.com>
In-Reply-To: <52a2f27bfe07_29836d5e98f5@nysa.notmuch>

On Sat, Dec 7, 2013 at 4:03 AM, Felipe Contreras <felipe.contreras@gmail.com> wrote:

Show 29 quoted lines

> Junio C Hamano wrote:
>> * fc/transport-helper-fixes (2013-11-13) 12 commits
>>  - remote-bzr: support the new 'force' option
>>  - transport-helper: add support to delete branches
>>  - fast-export: add support to delete refs
>>  - fast-import: add support to delete refs
>>  - transport-helper: add support for old:new refspec
>>  - fast-export: add new --refspec option
>>  - fast-export: improve argument parsing
>>  - test-hg.sh: tests are now expected to pass
>>  - transport-helper: check for 'forced update' message
>>  - transport-helper: add 'force' to 'export' helpers
>>  - transport-helper: don't update refs in dry-run
>>  - transport-helper: mismerge fix
>>
>>  Updates transport-helper, fast-import and fast-export to allow the
>>  ref mapping and ref deletion in a way similar to the natively
>>  supported transports.
>>
>>  The option name "--refspec" needs to be rethought. It does not mean
>>  what refspec usually means, even though it shares the same syntax
>>  with refspec; calling it --refspec only because it shares the same
>>  syntax is like calling it --asciistring and does not make sense.
>
> Not true. remote.<name>.fetch is a refspec, and doesn't specify what to fetch,
> so does the "refspec" capability in remote helpers, and so does the proposed
> --refspec option.
>
> It is exactly what it already means.

Not to mention that you can apply the first part of the series without any problems:

Show 6 quoted lines

>>  - fast-export: improve argument parsing
>>  - test-hg.sh: tests are now expected to pass
>>  - transport-helper: check for 'forced update' message
>>  - transport-helper: add 'force' to 'export' helpers
>>  - transport-helper: don't update refs in dry-run
>>  - transport-helper: mismerge fix

Even:

>>  - remote-bzr: support the new 'force' option

The rest is for old:new :to-delete refspecs.

To take hostage the whole patch series because of the name --refspec (which is perfectly fine) is just an excuse to not fix the issues already present.

-- 
Felipe Contreras