Re: [PATCH v2 2/4] transport-helper: add no-private-update capability
On Mon, Sep 2, 2013 at 2:19 AM, Matthieu Moy <Matthieu.Moy@imag.fr> wrote:
Show 10 quoted lines
> Since 664059fb62 (Felipe Contreras, Apr 17 2013, transport-helper: update
> remote helper namespace), a 'push' operation on a remote helper updates
> the private ref by default. This is often a good thing, but it can also
> be desirable to disable this update to force the next 'pull' to re-import
> the pushed revisions.
>
> Allow remote-helpers to disable the automatic update by introducing a new
> capability.
>
> Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Acked-by: Felipe Contreras <felipe.contreras@gmail.com>
Or Reviewed-by, or whatever.
Show 24 quoted lines
> ---
> Change since v1: just changed the capability name.
>
> Documentation/gitremote-helpers.txt | 6 ++++++
> git-remote-testgit.sh | 1 +
> t/t5801-remote-helpers.sh | 11 +++++++++++
> transport-helper.c | 7 +++++--
> 4 files changed, 23 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/gitremote-helpers.txt b/Documentation/gitremote-helpers.txt
> index 0827f69..1eacf1e 100644
> --- a/Documentation/gitremote-helpers.txt
> +++ b/Documentation/gitremote-helpers.txt
> @@ -120,6 +120,12 @@ connecting (see the 'connect' command under COMMANDS).
> When choosing between 'push' and 'export', Git prefers 'push'.
> Other frontends may have some other order of preference.
>
> +'no-private-update'::
> + When using the 'refspec' capability, git normally updates the
> + private ref on successful push. This update is disabled when
> + the remote-helper declares the capability
> + 'no-private-update'.
> +
>
There's an extra unnecessary space here, no?
--
Felipe Contreras
Felipe Contreras <felipe.contreras@gmail.com>