Re: [PATCH 3/4] unpack-trees: trivial cleanup

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Jun 3, 2013, 20:51 UTC
Message-ID: <CAMP44s0rHtrf0aa6sgQxM=vsMcYXOt5Jian-wuP9AA_rXesBmw@mail.gmail.com>
In-Reply-To: <7vzjv7glrw.fsf@alter.siamese.dyndns.org>

On Mon, Jun 3, 2013 at 12:13 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> dfc has not been initialized at this point.
>>
>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>> ---
>
> Upon the first entry to this function, because dfc is
>
>         static struct cache_entry *dfc;

Ah, I didn't notice it's static. Smells error-prone, but I guess it's OK for now.

-- 
Felipe Contreras