git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v7] Add new git-related helper to contrib

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 31, 2013, 07:49 UTC
Message-ID
<CAMP44s0peXDtFB31pEqF49xM8z5OtDKAWaOR65aZSkCndL2bhQ@mail.gmail.com>
In-Reply-To
<CAMP44s25vX1p1Np7yqc9_AqVBme+MCTY88hjhfWdL6KZkxgs7Q@mail.gmail.com>

On Thu, May 30, 2013 at 6:31 AM, Felipe Contreras <felipe.contreras@gmail.com> wrote:

> On Thu, May 30, 2013 at 4:01 AM, Ramkumar Ramachandra
> Not a single one of these comments makes a difference at all, all of
> them can wait until after the patch is merged, many of them are a
> matter of preferences, and some of them have already been addressed as
> precisely that: disagreements in style.

I was going to make these stylistic changes to make you happy, but then I realized the only that does really make sense is to change msg = nil to msg = false, and it's not even worth to waste a thought on changes like that.

So I'll move on to the next patches, hopefully Duy or Junio would have some comments of actual significance, or maybe you would too, but for the moment it seems pretty clear you are only stating opinions about what Ruby code-style you like best.

Cheers.
-- 
Felipe Contreras
Previous: Felipe ContrerasNext: Ramkumar Ramachandra
Message 6 of 9 in “Add new git-related helper to contrib”
  1. Add new git-related helper to contribFelipe Contreras, May 30, 2013
  2. Ramkumar RamachandraMay 30, 2013
  3. Felipe ContrerasMay 30, 2013
  4. Ramkumar RamachandraMay 30, 2013
  5. Felipe ContrerasMay 30, 2013
  6. Felipe ContrerasMay 31, 2013
  7. Ramkumar RamachandraMay 31, 2013
  8. Felipe ContrerasMay 31, 2013
  9. Ramkumar RamachandraMay 31, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.