Re: [PATCH v4 01/11] Add new git-related helper to contrib

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 26, 2013, 22:52 UTC
Message-ID: <CAMP44s0nvWvicFAJEqe0jC+zT3ZvA=Qx3MWXK36zYb2-uYV-aA@mail.gmail.com>
In-Reply-To: <1366919983-27521-2-git-send-email-felipe.contreras@gmail.com>

Hi,

On Thu, Apr 25, 2013 at 2:59 PM, Felipe Contreras <felipe.contreras@gmail.com> wrote:

Show 11 quoted lines

> This script find people that might be interested in a patch, by going
> back through the history for each single hunk modified, and finding
> people that reviewed, acknowledge, signed, or authored the code the
> patch is modifying.
>
> It does this by running 'git blame' incrementally on each hunk, and then
> parsing the commit message. After gathering all the relevant people, it
> groups them to show what exactly was their role when the participated in
> the development of the relevant commit, and on how many relevant commits
> they participated. They are only displayed if they pass a minimum
> threshold of participation.

Is this patch still not understandable? If so, I would gladly strip away functionality, like the ability to show the roles. But for the functionality it provides, I don't see how it could be any simpler.

Sure, code comments might help, but first I would like to make the code as self-documenting as possible, so I would give a try at a simplified version first, and then perhaps adding a Person object.

Better for me if the code was good enough as it is though.

Cheers.

-- 
Felipe Contreras