Re: [PATCH 2/4] transport-helper: check if remote helper is alive

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 2, 2013, 04:58 UTC
Message-ID: <CAMP44s0m_Jzn=DBEwkZjJqrxU1MoAs1V3ES5C2cdSK5Eg9cROQ@mail.gmail.com>
In-Reply-To: <7v38v9ixqn.fsf@alter.siamese.dyndns.org>

On Mon, Apr 1, 2013 at 6:26 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

> OK, so the idea is that fetch_with_import() does
>
>  - get_helper(transport), which spawns a helper process;
>
>  - get_importer(transport, &fastimport), which spawns a fast-import
>    and make it read from the output of the helper process;
>
>  - we did finish_command() to wait for the fast-import to finish,
>    expecting that the fast-import would finish when the helper stops
>    feeding it, which in turn would mean the helper would have died.
>
> The same for the pushing side.

The difference with the pushing side is that it's the helper the one waiting for fast-export and it can easily die.

Show 5 quoted lines

> Shouldn't transport_disconnect() have called release_helper() which
> in turn calls disconnect_helper() to call finish_command() on the
> helper to wait for that procesanyway?  Is somebody discarding return
> value from transport_disconnect() or the current calling site of
> transport_disconnect() is too late to notice the error?

It's too late to notice the error. However, only in the case of pushing.

-- 
Felipe Contreras