git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 2/3] completion: add new __gitcompadd helper

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Oct 30, 2012, 23:05 UTC
Message-ID
<CAMP44s0dctpjobNNRTOFcX4ir+nzenTZMNWFbEvBa-QU93psbA@mail.gmail.com>
In-Reply-To
<20121030225839.GO12052@goldbirke>
On Tue, Oct 30, 2012 at 11:58 PM, SZEDER Gábor <szeder@ira.uka.de> wrote:
Show 11 quoted lines
> On Mon, Oct 22, 2012 at 03:45:41AM +0200, Felipe Contreras wrote:
>> The idea is to never touch the COMPREPLY variable directly.
>>
>> This allows other completion systems override __gitcompadd, and do
>> something different instead.
>>
>> Also, this allows the simplification of the completion tests (separate
>> patch).
>
> This doesn't apply anymore, does it?  The mentioned simplification is
> done in the other series.

Yeah, but you mentioned you didn't like all the COMPREPLY=() changes and it might be time to get rid of them.

So this series supersedes that one.
-- 
Felipe Contreras
Previous: SZEDER GáborNext: SZEDER Gábor
Message 5 of 8 in “completion: refactor and zsh wrapper”
  1. 0/3 completion: refactor and zsh wrapperFelipe Contreras, Oct 22, 2012
  2. 1/3 completion: get rid of empty COMPREPLY assignmentsFelipe Contreras, Oct 22, 2012
  3. 2/3 completion: add new __gitcompadd helperFelipe Contreras, Oct 22, 2012
  4. SZEDER GáborOct 30, 2012
  5. Felipe ContrerasOct 30, 2012
  6. SZEDER GáborOct 31, 2012
  7. 3/3 completion: add new zsh completionFelipe Contreras, Oct 22, 2012
  8. Felipe ContrerasOct 30, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.