Re: [PATCH] completion: zsh: improve bash script loading

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 29, 2013, 19:30 UTC
Message-ID: <CAMP44s0VjXwOXhUvniui+yVJiH4Dwxtx=0431G2KrEdHtrGTDw@mail.gmail.com>
In-Reply-To: <7vr4gpu15c.fsf@alter.siamese.dyndns.org>

On Wed, May 29, 2013 at 12:49 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 23 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> On Wed, May 29, 2013 at 1:17 AM, Johannes Sixt <j.sixt@viscovery.net> wrote:
>>> Am 5/29/2013 5:24, schrieb Felipe Contreras:
>>>> +if [ -z "$script" ]; then
>>>> +     local -a locations
>>>> +     locations=(
>>>> +             '/etc/bash_completion.d/git' # fedora, old debian
>>>> +             '/usr/share/bash-completion/completions/git' # arch, ubuntu, new debian
>>>> +             '/usr/share/bash-completion/git' # gentoo
>>>> +             $(dirname ${funcsourcetrace[1]%:*})/git-completion.bash
>>>> +             )
>>>
>>> Won't you need
>>>
>>>         local e
>>>
>>> here, or does it not matter?
>>
>> You are right, otherwise it would be in the user's shell.
>
> Has this changed since 0a04e187e669 (completion: zsh: improve bash
> script loading, 2013-05-24) which I have on 'pu'?

Other than this change, nope.

> If not, I can do this locally to save a roundtrip, if you want.

Great, let's do that.

-- 
Felipe Contreras