Re: [PATCH 1/3] fetch: add --allow-local option

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 16, 2013, 16:52 UTC
Message-ID: <CAMP44s0Szu8oHBKMapZ6dQ1K67MXDcACuUF-+Y-jC+EgHs2QEA@mail.gmail.com>
In-Reply-To: <7v8v3e7udi.fsf@alter.siamese.dyndns.org>

On Thu, May 16, 2013 at 11:38 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> That doesn't change the fact that 'git fetch .' does not make any
>> sense whatsoever. The user *will* get confused when (s)he does 'git
>> fetch' and nothing happens. The problem is not solved.
>>
>> % git checkout -b fixes master
>> % git fetch
>> % git branch -u master
>> % git fetch
>>
>> # scratch head
>
> # reads manual, perhaps?

You expect too much from users. But...

% man git push /default

Nothing.

> Why do you declare without justification that "git fetch ." does not
> make sense?

What does 'git fetch .' do?

> If you come from "git pull" is "git fetch" + "git merge",
> and if your current branch is integrating with your local branch,

How many times do I have to say that 'git pull' is not 'git fetch' + 'git merge'?

You must think everybody has 'merge.defaulttoupstream=true'.

Show 6 quoted lines

> it
> is natural that "git fetch" that does not say where to fetch from
> fetches from your local repository (object-transfer wise, it is a
> no-op) and update FETCH_HEAD.  You can say "it is not necessary, as
> we can directly go to @{u}", but that is different from "it does not
> make any sense".

It literally does not make any sense. From the point of view of the typical user it does nothing.

Show 5 quoted lines

> I think the real cause of the problem is that some people advocate
> the use of "git fetch" that does not say "from where" and "get
> what".  When the user understand what it does and what it does it
> for, not having to type is a convenience, but as a recipe to be
> blindly followed, it leaves the new people in the dark.

That's totally irrelevant. Whether the user knows all the details or not doesn't matter. Typing less is good, and it's important that commands without arguments do something sane, and 'git fetch' doesn't. The user should not be forced to type the remote when it's not necessary, and wasting the 'git fetch' command to do absolutely nothing is not smart.

-- 
Felipe Contreras