Re: [PATCH] Makefile: suppress false positive warnings of empty format string.

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Sep 29, 2013, 15:07 UTC
Message-ID: <CAMP44s069BUJiv1K3a2nkwT1A8fo=Vn0+8WFePHqBg_PBx_17g@mail.gmail.com>
In-Reply-To: <1380456534-7582-1-git-send-email-stefanbeller@googlemail.com>

On Sun, Sep 29, 2013 at 7:08 AM, Stefan Beller <stefanbeller@googlemail.com> wrote:

Show 15 quoted lines

> Signed-off-by: Stefan Beller <stefanbeller@googlemail.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index de3d72c..60afa51 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -349,7 +349,7 @@ GIT-VERSION-FILE: FORCE
>
>  # CFLAGS and LDFLAGS are for the users to override from the command line.
>
> -CFLAGS = -g -O2 -Wall
> +CFLAGS = -g -O2 -Wall -Wno-format-zero-length

Oh yes please.

However, somebody mentioned that this might break compilers other than gcc, but perhaps we can do what Linux does:

cc-disable-warning = $(call try-run,\ $(CC) $(CFLAGS) -W$(strip $(1)) -c -x c /dev/null -o "$$TMP",-Wno-$(strip $(1)))

CFLAGS = -g -O2 -Wall $(call cc-disable-warning,format-zero-length,)

-- 
Felipe Contreras