Re: [GSoC] [PATCH] travis-ci: added clang static analysis

From: Siddhartha Mishra <sidm1999@gmail.com>
Date: Mar 6, 2018, 08:34 UTC
Message-ID: <CAMOtk6BafDOX6PkOs=KVPp5rf1wF3Zq9ZWMAiKgw+EN2KTsndg@mail.gmail.com>
In-Reply-To: <xmqqpo4i6lj0.fsf@gitster-ct.c.googlers.com>

On Tue, Mar 6, 2018 at 6:57 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

> SiddharthaMishra <sidm1999@gmail.com> writes:
>
>> Added a job to run clang static code analysis on the master and maint branch
>>
>> Signed-off-by: SiddharthaMishra <sidm1999@gmail.com>
>> ---
>
> Why on 'master' and 'maint' and not others?  Quite frankly, I find
> this choice of branches rather odd, as these two branches are not
> where the real development happens.  If we do not want to increase
> the number of jobs and limit the test only to a single branch, I
> would probably pick 'next', and if we can afford two, probably
> 'pu' and 'next'.

I might have been misinterpreting it, but I did so because that's what it said in the microproject description. Thinking about it, I guess it does makes more sense to work on the other two branches instead. Are there any other glaring issues you see in the code?