Re: [PATCH] rebase: add a config option for --no-fork-point

From: Alex Henrie <alexhenrie24@gmail.com>
Date: Jan 21, 2021, 23:51 UTC
Message-ID: <CAMMLpeTDNLUz9UVnL3aVK=J7X50Sq8L-OVGaoEsT5AY6EQON-g@mail.gmail.com>
In-Reply-To: <YAoSIkCecZU98QD2@generichostname>

On Thu, Jan 21, 2021 at 4:45 PM Denton Liu <liu.denton@gmail.com> wrote:

Show 8 quoted lines

>
> On Thu, Jan 21, 2021 at 04:25:25PM -0700, Alex Henrie wrote:
> > I didn't see any fork-point tests in the current codebase, but I can
> > work on adding some. Do you want them in a separate patch (that would
> > make the most sense to me), or squashed into the rebase.forkPoint
> > patch?
>
> The fork-point tests should be in t3431.

Derp! For some reason I thought that t3431 only tested --fork-point with an ambiguous refname and that the other tests were unrelated. Maybe we should make copies of some of those tests that set rebase.forkPoint instead of passing --fork-point or --no-fork-point on the command line.

-Alex