Re: Pick the right default and stop warn on `git pull`

From: Alex Henrie <alexhenrie24@gmail.com>
Date: Nov 24, 2020, 23:23 UTC
Message-ID: <CAMMLpeQvofhPjcJ19JrqJs1W3YoQSP+hOainuZJa=QeJzYc+5w@mail.gmail.com>
In-Reply-To: <CAMP44s2z3vv2LwoMesydVL3qWrJh0VvHSUy+FpnqguoipRRD9g@mail.gmail.com>

On Tue, Nov 24, 2020 at 3:11 PM Felipe Contreras <felipe.contreras@gmail.com> wrote:

>
> Before making "pull.ff=only" the default, we need a transitional
> period in which if it's unset, a warning is printed when pulling a
> non-fast-forward branch. This is what my patch did several years ago.

We'd only need a warning if both pull.ff and pull.rebase are unset, since that's the only situation where the behavior would change. And providentially, we already have a warning in that exact case, although we should probably tweak it to explain what the new behavior is going to be :-)

> And yes, it should be possible to do what you suggest, but have you
> tried? I suspect both the code and the documentation would be quite
> convoluted.

Yes, I have written a very simple patch that implements the behavior that I am suggesting. I will send it to the mailing list later tonight.

-Alex