Re: [PATCH] gitk: Remove mc parameter from proc show_error
2015-05-02 4:05 GMT-06:00 Paul Mackerras <paulus@samba.org>:
Show 19 quoted lines
> To test this, I changed {package require Tk 8.4} to {package require
> Tk 8.7}, in order to deliberately trigger the error. When I run gitk
> with that change (and your patch applied), I get this in the xterm
> where I run gitk:
>
> $ ./gitk
> Error in startup script: invalid command name "mc"
> while executing
> "mc OK"
> (procedure "show_error" line 7)
> invoked from within
> "show_error {} . "Sorry, gitk cannot run with this version of Tcl/Tk.\n Gitk requires at least Tcl/Tk 8.4.""
> invoked from within
> "if {[catch {package require Tk 8.7} err]} {
> show_error {} . "Sorry, gitk cannot run with this version of Tcl/Tk.\n\
> Gitk requires at least ..."
> (file "./gitk" line 12012)
>
> and no pop-up window. So this patch still isn't quite right.Good point. We can fix this by importing ::msgcat::mc earlier.
> Given that old versions of tcl/tk probably don't have [mc], I think
> it's inevitable that "OK" will have to be untranslated for that
> particular error path.
msgcat and ::msgcat::mc were added in Tcl 8.1a2, released Febuary 23,
1998. See the "changes" file in
<ftp://ftp.tcl.tk/pub/tcl/tcl8_1/tcl8.1.tar.gz>. Surely you are not
trying to support Tcl 8.0 and earlier, so we should be able to use mc
all we want.
-Alex
Alex Henrie <alexhenrie24@gmail.com>