Re: [PATCH] stash: Add stash.showFlag config variable

From: Namhyung Kim <namhyung@gmail.com>
Date: Aug 29, 2015, 15:19 UTC
Message-ID: <CAM9d7cg4k=H9GY=CihuHdyH1yj-z4EUkKsWrDO0DXKx3QwDejw@mail.gmail.com>
In-Reply-To: <xmqqy4gv1dyr.fsf@gitster.mtv.corp.google.com>

Hi,

On Sat, Aug 29, 2015 at 3:10 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

> Namhyung Kim <namhyung@gmail.com> writes:
>
>>> Perhaps a pair of new booleans
>>>
>>>  - stash.showStat (defaults to true but you can turn it off)
>>>  - stash.showPatch (defaults to false but you can turn it on)
>>>
>>> or something along that line might be sufficient and more palatable.
>>
>> Hmm.. I agree with you, but I don't know what we should do if both of
>> the options were off.  Just run 'git diff' with no option is ok to you?
>
> If the user does not want stat or patch, then not running anything
> would be more appropriate, don't you think?

Ah, ok. :)  I'll change that way and send v3 soon!

Thanks, Namhyung