Re: [PATCH 3/3] t1404: use 'test_must_fail stderr=<file>'

From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Feb 9, 2018, 03:33 UTC
Message-ID: <CAM0VKjnnt0Nq6GQXWaq6Jq_tvOzJx-KsEBjs-7NS2bim0UH+Og@mail.gmail.com>
In-Reply-To: <CAPig+cTtC8WaqJg301WE+EN2RYzka-+pOoJZNZFzjqsHtx+M-Q@mail.gmail.com>

On Fri, Feb 9, 2018 at 4:16 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 8 quoted lines

> On Thu, Feb 8, 2018 at 9:42 PM, SZEDER Gábor <szeder.dev@gmail.com> wrote:
>> Instead of 'test_must_fail git cmd... 2>output.err', which redirects
>> the standard error of the 'test_must_fail' helper function as well,
>> causing various issues as discussed in the previous patch.
>
> ECANTPARSE: This either wants to say:
>
>     "Instead of <foo>, do <bar>."

The "do <bar>" part is in the subject line.

> or:
>
>     "'test_must_fail ... 2>...', which redirects ...
>      causes various issues discussed..."

Well, at this point I got the ECANTPARSE :)

Show 6 quoted lines

> but fails to say either.
>
>> With this patch t1404 succeeds when run with '-x', even with shells
>> not supporting $BASH_XTRACEFD.
>>
>> Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>