Re: [PATCH v1.1 1/2] t9400-git-cvsserver-server: don't rely on the output of 'test_cmp'
- From
SZEDER Gábor <szeder.dev@gmail.com>
- Date
- Mar 9, 2018, 11:20 UTC
- Message-ID
- <CAM0VKjnfNBGd4BPXGbpGSTH_YW8dfX=19Lr-DCcS=B5BHp_nCg@mail.gmail.com>
- In-Reply-To
- <xmqqvae66ske.fsf@gitster-ct.c.googlers.com>
On Fri, Mar 9, 2018 at 12:44 AM, Junio C Hamano <gitster@pobox.com> wrote:
> SZEDER Gábor <szeder.dev@gmail.com> writes:
Show 6 quoted lines
>>> This makes "rm -f failures &&" unnecessary, no? >> >> Indeed, it does. > > OK, no need to resend, as I'll amend it locally before queuing > (unless there is something else that needs updating, that is).
Thanks.
That 'rm' was unnecessary to begin with, because none of the previous tests wrote and left behind a file 'failures', ever. Though one could argue that the original author was careful and added that 'rm failures' as a protection against future changes to previous tests... Dunno, we are talking about a test that checked the stderr of 'test_cmp', so anything is possible :)