Re: [PATCHv4 1/1] git-p4: add unshelve command

From: SZEDER Gábor <szeder.dev@gmail.com>
Date: May 21, 2018, 22:22 UTC
Message-ID: <CAM0VKj=OL28HiwiU8F=vg7+=Vt=Ng8W3=15Q-2fs=f0bEFTUtA@mail.gmail.com>
In-Reply-To: <CAE5ih7-1LwLxndEdjtGEmoViiZYbspkjymTzWxnnMgVWfNW2_w@mail.gmail.com>

On Tue, May 22, 2018 at 12:09 AM, Luke Diamand <luke@diamand.org> wrote:

Show 11 quoted lines

> On 21 May 2018 at 22:39, SZEDER Gábor <szeder.dev@gmail.com> wrote:
>>> diff --git a/t/t9832-unshelve.sh b/t/t9832-unshelve.sh
>
> ...
> ...
>
>>> +'
>>
>> This test fails on my box and on Travis CI (in all four standard Linux
>> and OSX build jobs) with:
>>

Show 11 quoted lines

>>     File "/home/szeder/src/git/git-p4", line 2467, in cmp_shelved
>>       return ret["status"] == "identical"
>>   KeyError: 'status'
>>   error: last command exited with $?=1
>>   not ok 4 - create shelved changelist
>
> It works fine for me - but given where it's failing, my first
> suspicion would be p4 client version (or server) differences.
>
> I'm using 2015.1 for server and client. Could you check which version
> you are using?

Well, sending a bug report and not including the version used... totally rookie move. Sorry :)

I downloaded the same version used by the Travis CI Linux build jobs, which is:

  Rev. P4/LINUX26X86_64/2016.2/1598668 (2017/12/08).
  Rev. P4D/LINUX26X86_64/2016.2/1648692 (2018/04/16).

The OSX build jobs used whatever current version they got via homebrew:

  Rev. P4/DARWIN90X86_64/2017.2/1611521 (2018/01/21).
  Rev. P4D/DARWIN90X86_64/2017.2/1650199 (2018/04/18).