Re: What's cooking in git.git (Aug 2025, #01; Sun, 3)

From: D. Ben Knoble <ben.knoble@gmail.com>
Date: Aug 5, 2025, 01:22 UTC
Message-ID: <CALnO6CDm5n0oZsXzvKz89jVg7E_h=1gqPFs2x7-UojdcY_Di_w@mail.gmail.com>
In-Reply-To: <xmqqms8fbilv.fsf@gitster.g>

On Mon, Aug 4, 2025 at 4:23 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 11 quoted lines

> * dk/help-all (2025-08-03) 4 commits
>  - builtin: also setup gently for --help-all
>  - parse-options: refactor flags for usage_with_options_internal
>  - t1517: fixup for ua/t1517-short-help-tests
>  - Merge branch 'ua/t1517-short-help-tests' into dk/help-all
>  (this branch uses ua/t1517-short-help-tests.)
>
>  "git cmd --help-all" outside repository.
>
>  Breaks t1517.296 under SANITIZE=leak?
>  source: <20250803012613.54086-1-ben.knoble+github@gmail.com>

I don't see the link in the linux-leaks job of a recent CI run [1]. When I build with

    make SANITIZE=leak CC=gcc-14

(since clang on my system doesn't support -fsantize=leak for x86_64-apple-darwin21.6.0) and then

    (cd t && prove t1517*)

then I get

    t1517-outside-repo.sh .. ok
    All tests successful.
    Files=1, Tests=392, 22 wallclock secs ( 0.10 usr  0.01 sys +  5.26
cusr  4.40 csys =  9.77 CPU)
    Result: PASS

So I don't think this topic is the problem. This is true whether I use my copy of the topic or the one you publish (4c8db1e55c (builtin: also setup gently for --help-all, 2025-08-03)).

[1]: https://github.com/benknoble/git/actions/runs/16706744996/job/47285921358