Re: [PATCH] rebase: add `--update-refs=interactive`

From: D. Ben Knoble <ben.knoble@gmail.com>
Date: Feb 11, 2025, 19:28 UTC
Message-ID: <CALnO6CDN627+SUC6BWBvVjFnU5qKsBrfLkmX2okv8J8+wgDDRA@mail.gmail.com>
In-Reply-To: <bc0de52b59f289e1388f1581fcfa49453365e21a.camel@intelfx.name>

On Tue, Feb 11, 2025 at 6:33 AM Ivan Shapovalov <intelfx@intelfx.name> wrote:

Show 14 quoted lines

>
> On 2025-02-10 at 15:22 -0500, D. Ben Knoble wrote:
> >
> > Based on `git grep -e '--.*\[=' Documentation/git-*.txt`, I think this
> > should be more like
> >
> >     --update-refs[=interactive]::
> >     --no-update-refs::
> >
> > But maybe that unintentionally suggests that `=interactive` is the default?
>
> Perhaps --update-refs[=(yes|no|interactive)] then? Or is that too
> verbose? Anyway, I don't have a preference, I'll just do what I'm told
> here.

I don't have a strong opinion, and I think this is being discussed elsewhere in this thread.

Show 8 quoted lines

> > Should we add a test for this?
> >
>
> Any suggestions what exactly I should test here? I don't have much
> experience testing interactive CLI tools, so I'd appreciate some hints.
>
> --
> Ivan Shapovalov / intelfx /

Give t/README a glance; t3404 is probably a good place to start given "git grep update-refs t."

-- 
D. Ben Knoble