.mailmap etiquette (was "Re: [PATCH 1/7] parse-options: introduce OPT_HIDDEN_GROUP")
- From
D. Ben Knoble <ben.knoble@gmail.com>
- Date
- Jul 16, 2026, 22:14 UTC
- Message-ID
- <CALnO6CCauJhCmgKjV6QJ44cZD=2ah6=rJaV0+2ZMYTo7ycghEA@mail.gmail.com>
- In-Reply-To
- <xmqqcxwmeiwq.fsf@gitster.g>
On Thu, Jul 16, 2026 at 5:17 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 32 quoted lines
>
> Christian Couder <christian.couder@gmail.com> writes:
>
> > Hidden options are not shown by `git <cmd> -h`, but are still shown by
> > `git <cmd> --help-all`. If there are a lot of hidden options or if they
> > don't belong to the same categories as other options, there is
> > currently no way to properly group them.
> >
> > Using `OPT_GROUP("Foo")` means that "Foo" will always be shown which we
> > don't want if that group contains only hidden options.
> >
> > To provide a way to have groups shown only when hidden options are
> > shown, let's implement an OPT_HIDDEN_GROUP macro.
> >
> > To test this new macro, let's also improve `test-tool parse-options`
> > and test its output with `--help-all`.
> >
> > Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> > ---
>
> We have been doing this for quite some time, but I just noticed
> that the 'From' address your MUA uses ("Christian Couder
> <christian.couder@gmail.com>") does not match your Sign-off. Could
> you add an in-body 'From:' line if you plan to keep sending your
> patches from the Gmail address?
>
> I suppose nobody has noticed it so far because .mailmap hides the
> discrepancy once the commit lands.
>
> The changes in this step looks alright, though.
>
> Thanks.Speaking of .mailmap… if I were going to send future patches under a new email address, would you prefer
(a) a series with the 1st commit being a .mailmap update (subsequent commits bearing the new email address, of course, but unrelated to the .mailmap update) (b) a one-patch email with a .mailmap update (c) the same as (b), but only after commits with the new email address have stabilized in next or master
?
[PS happy to drop anyone from CC who doesn't want this one; list etiquette is a bit unclear to me on this kind of subject change, though I would lean towards emptying CC and keeping only Junio…]
-- D. Ben Knoble