git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] replay: drop rev-list formatting options from manual

From
D. Ben Knoble <ben.knoble+github@gmail.com>
Date
Jan 20, 2026, 14:04 UTC
Message-ID
<CALnO6CCaVdJQ2xSPfvxQzVCfPsjbWHhMFUiLoiPQtVn9MeKFOw@mail.gmail.com>
In-Reply-To
<xmqqldht2fgd.fsf@gitster.g>
On Mon, Jan 19, 2026 at 9:19 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 33 quoted lines
>
> "D. Ben Knoble" <ben.knoble+github@gmail.com> writes:
>
> > The rev-list options in our manuals are quite long; git-replay's manual
> > is no exception. Since replay doesn't use the formatting options at all
> > (it has its own output format), drop them.
> >
> > Signed-off-by: D. Ben Knoble <ben.knoble+github@gmail.com>
> > ---
> >
> > Notes (benknoble/commits):
> >     I noticed this while reading. It took me a minute to find the
> >     Asciidoc reference on multiple attributes [1] since it's not used
> >     elsewhere in the rev-list include :) I'm not sure it needs to be
> >     included in the commit message, though normally I would, personally.
> >
> >     [1]: https://docs.asciidoctor.org/asciidoc/latest/directives/ifdef-ifndef/
>
>
> Indeed.  Not just rev-list, but ifdef:: or ifndef:: anywhere do not
> check multiple attributes in existing docs.
>
> "ifndef::git-shortlog,git-replay[]" is rather hard to follow, as it
> is unclear if they are ANDed or ORed, and it does not help to have
> it with negation X-<.  I guess there always is the first instance,
> and we need to get used to it ;-)
>
> As long as the construct is understood correctly with AsciiDoc and
> Asciidoctor (two renderers we depend on), it is OK, but I do agree
> with you it deserves to be said in the log message that you noticed
> this is the first time we use the syntax.
>
> Thanks.
Extra sentences coming in v2 then ;)
RE: AsciiDoc vs. Asciidoctor, it was a bit difficult for me to
untangle https://docs.asciidoctor.org/ and https://asciidoc.org/
(which points quite a bit at the former for specs/docs). It seems that
by AsciiDoc you refer to the legacy Python processor
(https://github.com/asciidoc-py/asciidoc-py/), and then Asciidoctor is
presumably the Ruby processor
(https://github.com/asciidoctor/asciidoctor)?

If I've understood all that correctly, then I have the Python version installed for building Git and it understood the syntax. Given that the Ruby version is newer, I think it should also work against the spec.

Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 11 in “replay: drop rev-list formatting options from manual”
  1. replay: drop rev-list formatting options from manualD. Ben Knoble, Jan 20, 2026
  2. Junio C HamanoJan 20, 2026
  3. D. Ben KnobleJan 20, 2026
  4. Junio C HamanoJan 20, 2026
  5. Junio C HamanoJan 20, 2026
  6. Junio C HamanoJan 20, 2026
  7. Jean-Noël AvilaJan 21, 2026
  8. Junio C HamanoJan 21, 2026
  9. D. Ben KnobleJan 21, 2026
  10. D. Ben KnobleJan 27, 2026
  11. replay: drop rev-list formatting options from manualD. Ben Knoble, Jan 20, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.