Re: [PATCH] last-modified: implement faster algorithm

From: D. Ben Knoble <ben.knoble@gmail.com>
Date: Oct 16, 2025, 20:48 UTC
Message-ID: <CALnO6CBwuAdBFjESZSYZkChNdU9R17OXDc+CY=Z96QoACPgrpQ@mail.gmail.com>
In-Reply-To: <20251016-b4-toon-last-modified-faster-v1-1-85dca8a29e5c@iotcl.com>

On Thu, Oct 16, 2025 at 4:39 AM Toon Claes <toon@iotcl.com> wrote:

> As an added benefit, this implementation gives more correct results. For
> example implementation in 'master' gives:

"More correct" is a bit of an oxymoron, no? It's either correct or it's not :)

Show 9 quoted lines

>
>     $ git log --max-count=1 --format=%H -- pkt-line.h
>     15df15fe07ef66b51302bb77e393f3c5502629de
>
>     $ git last-modified -- pkt-line.h
>     15df15fe07ef66b51302bb77e393f3c5502629de    pkt-line.h
>
>     $ git last-modified | grep pkt-line.h
>     5b49c1af03e600c286f63d9d9c9fb01403230b9f    pkt-line.h

It seems this commit is the merge to a maintenance branch, which was authored and committed after the mainline merge but topologically we'd probably consider it "earlier," at least starting from master? Anyway, I'm not clear why this result was produced.

Thanks!

-- 
D. Ben Knoble