Re: git-replay/git-history lose notes

From: D. Ben Knoble <ben.knoble@gmail.com>
Date: Aug 5, 2026, 13:05 UTC
Message-ID: <CALnO6CAxr2+SV-1YrJBsb2LPqmzxnRSiPYXPqRQs384bwUO+mg@mail.gmail.com>
In-Reply-To: <975a0661-945c-4a03-bad1-14db929c8d97@gmail.com>

On Wed, Aug 5, 2026 at 9:00 AM Phillip Wood <phillip.wood123@gmail.com> wrote:

Show 7 quoted lines

>
> On 05/08/2026 12:39, D. Ben Knoble wrote:
> > On Wed, Aug 5, 2026 at 2:27 AM Patrick Steinhardt <ps@pks.im> wrote:
> >>
> >> Hi,
> >>
> >> On Tue, Aug 04, 2026 at 04:06:38PM -0400, D. Ben Knoble wrote:

[snip]

Show 16 quoted lines

> >>> Are notes out of scope for replay and history, or is this just a
> >>> "nobody's gotten around to it yet"?
> >>
> >> For git-replay(1) I'm not too sure, as I consider that command to be
> >> part of plumbing. But git-history(1) is a user-facing command, and
> >> because of that I think it should handle notes automatically for the
> >> user.
> >
> > I can't speak for replay, although I do use it as a convenient "rebase
> > a bunch of local branches that have conflicts without checking each
> > one out"… but the history part makes sense to me.
>
> I think having a command line option for replay to turn on note copying
> would be useful (and as a plumbing command we may not want the behavior
> changing via config). The implementation will probably want to live in
> the shared code anyway.

See also notes.rewrite.<command>, perhaps? Although your point about config makes sense.

-- 
D. Ben Knoble