Re: [GSoC PATCH v2] userdiff: add builtin driver for gitconfig syntax

From: D. Ben Knoble <ben.knoble@gmail.com>
Date: Mar 24, 2025, 20:23 UTC
Message-ID: <CALnO6CAsF1J39MeO-KY80bQfFL1V3UHT08-Va2R6QNh0JqwZ9A@mail.gmail.com>
In-Reply-To: <d4c0c9a4-0402-4456-9fa0-3102b5bcc3dc@kdbg.org>

On Mon, Mar 24, 2025 at 3:18 AM Johannes Sixt <j6t@kdbg.org> wrote:

Show 5 quoted lines

>
>
> You have now managed to avoid the "No newline at end of file", but have
> added a blank line instead. Not a big deal, but unconventional.
>

I missed the opportunity to reply to the original patch on this front,
but here's the information I usually give out:
- VS Code's default settings do not respect POSIX end-of-file newline
standards, so you should probably change them [1]
- There's a similar setting for Intellij IDEA [2] and Vim [3], but
they might have saner defaults (Vim certainly does)
- If your editor or IDE picks up on editorconfig settings, you'll be
able to avoid this
- Git can warn you with diff or show saying "No newline at end of
file," so a careful self-review also catches these.

[1]: https://stackoverflow.com/q/44704968/4400820 [2]: https://stackoverflow.com/q/16761227/4400820 [3]: https://vimhelp.org/options.txt.html#%27endofline%27

-- 
D. Ben Knoble