Re: [PATCH v2 2/4] doc: git-add: simplify discussion of ignored files
- From
D. Ben Knoble <ben.knoble@gmail.com>
- Date
- Aug 14, 2025, 00:59 UTC
- Message-ID
- <CALnO6CA2bv0CHcEW-n=VU0xZXHgSrpXV_Dc3Q+HAGV7=Mr-_8Q@mail.gmail.com>
- In-Reply-To
- <63c9e0361dc02c15afeea3cad1656e1631637f60.1755127218.git.gitgitgadget@gmail.com>
On Wed, Aug 13, 2025 at 7:20 PM Julia Evans via GitGitGadget <gitgitgadget@gmail.com> wrote:
Show 30 quoted lines
> > From: Julia Evans <julia@jvns.ca> > > - Mention the --force option earlier > - Remove the explanation of shell globbing vs git's internal glob > system, it's a common gotcha but I don't think this is an appropriate > place to explain that concept. There's some discussion of the gotchas > around globbing and `git add` in the EXAMPLES section which I think > is clearer. > > Signed-off-by: Julia Evans <julia@jvns.ca> > --- > Documentation/git-add.adoc | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/Documentation/git-add.adoc b/Documentation/git-add.adoc > index 949b016e6fa2..75e223f6b1ea 100644 > --- a/Documentation/git-add.adoc > +++ b/Documentation/git-add.adoc > @@ -39,12 +39,11 @@ you must run `git add` again to add the new content to the index. > The `git status` command can be used to obtain a summary of which > files have changes that are staged for the next commit. > > -The `git add` command will not add ignored files by default. If any > -ignored files were explicitly specified on the command line, `git add` > -will fail with a list of ignored files. Ignored files reached by > -directory recursion or filename globbing performed by Git (quote your > -globs before the shell) will be silently ignored. The `git add` command can > -be used to add ignored files with the `-f` (force) option. > +`git add` will not add ignored files by default. You can use the
Not worth a re-roll on its own, but this is another instance where starting a sentence with `git add` seems odd to me.
The range-diff in v2 looked good to me overall.
-- D. Ben Knoble