git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] clone: check if server supports shallow clones

From
Michael Edgar <adgar@google.com>
Date
Jun 10, 2015, 20:25 UTC
Message-ID
<CALkbG6+Xqw+giW3msUKYx4odFv+2GAi=C2t2d=6VjuFp0xpO0w@mail.gmail.com>
In-Reply-To
<20150610190512.GB22800@peff.net>
Show 5 quoted lines
> On Wed, Jun 10, 2015 at 3:05 PM, Jeff King <peff@peff.net> wrote:
> I see that do_fetch_pack checks server_supports("shallow"). Is that
> enough to cover all fetch cases? And if it is, why does it not cover the
> matching clone cases?
> -Peff

Great question. I determined that the do_fetch_pack logic doesn't work for clones because it also checks is_repository_shallow(), which looks for the .git/shallow file (or the alternate file).

I considered changing clone to create an empty .git/shallow file or alternate, but it turns out that an empty shallow file is treated as no shallow file at all. Since at this stage in cloning we have nothing to put in the shallow file, it seemed like any other fix would require more substantial changes.

Previous: Jeff KingNext: Jeff King
Message 3 of 12 in “clone: check if server supports shallow clones”
  1. clone: check if server supports shallow clonesMike Edgar, Jun 10, 2015
  2. Jeff KingJun 10, 2015
  3. Michael EdgarJun 10, 2015
  4. Jeff KingJun 10, 2015
  5. Duy NguyenJun 11, 2015
  6. Jeff KingJun 11, 2015
  7. Michael EdgarJun 11, 2015
  8. Junio C HamanoJun 11, 2015
  9. fetch-pack: check for shallow if depth givenMike Edgar, Jun 17, 2015
  10. Jeff KingJun 17, 2015
  11. Junio C HamanoJun 17, 2015
  12. Jeff KingJun 17, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.