Show 19 quoted lines
> If I were doing it, I might just ask the maintainer to make the
> decision for me, by making a somewhat funny patch series:
>
> 1. add "how to use the get_sha1 family" to Documentation/technical.
> 2. make get_sha1_with_context_1 static.
> 3. replace get_sha1_with_mode_1 with simpler die_sha1_not_in_index
> function.
> 4. add namelen argument to die_sha1_not_... and
> get_sha1_with_context, adjust callers, and make use of
> get_sha1_with_context with this arg in sequencer code.
> 5. add namelen arg to get_sha1_with_mode, adjust callers, and
> make sequencer code use this instead.
> 6. add namelen arg to get_sha1, adjust callers, and make sequener
> code use this instead.
>
> That way, the maintainer could take patches 1 - 3 to get the basic API
> cleanup, patch 4 to get the sequencer enhancement and make a judgement
> call about whether to take patches 5 and 6 depending on how much of a
> pain the churn would be given other patches in flight.
Ramkumar Ramachandra <artagnon@gmail.com>