git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rebase: fix run_specific_rebase's use of "return" on FreeBSD

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
Sep 9, 2013, 09:00 UTC
Message-ID
<CALkWK0nbcCuEfhagT4aUzqX8iynbhUvkRO9asmRHSGmEPRYZiA@mail.gmail.com>
In-Reply-To
<1378716795-5420-1-git-send-email-Matthieu.Moy@imag.fr>
Matthieu Moy wrote:
Show 22 quoted lines
> diff --git a/git-rebase.sh b/git-rebase.sh
> index 8d7659a..226752f 100755
> --- a/git-rebase.sh
> +++ b/git-rebase.sh
> @@ -167,13 +167,22 @@ You can run "git stash pop" or "git stash drop" at any time.
>         rm -rf "$state_dir"
>  }
>
> -run_specific_rebase () {
> +run_specific_rebase_internal () {
>         if [ "$interactive_rebase" = implied ]; then
>                 GIT_EDITOR=:
>                 export GIT_EDITOR
>                 autosquash=
>         fi
> +       # On FreeBSD, the shell's "return" returns from the current
> +       # function, not from the current file inclusion.
> +       # run_specific_rebase_internal has the file inclusion as a
> +       # last statement, so POSIX and FreeBSD's return will do the
> +       # same thing.
>         . git-rebase--$type
> +}
Most excellent. Thanks for fixing this.
Previous: Matthieu MoyNext: Junio C Hamano
Message 2 of 3 in “rebase: fix run_specific_rebase's use of "return" on FreeBSD”
  1. rebase: fix run_specific_rebase's use of "return" on FreeBSDMatthieu Moy, Sep 9, 2013
  2. Ramkumar RamachandraSep 9, 2013
  3. Junio C HamanoSep 9, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.